On Fri, 25 Apr 2025 00:52:04 GMT, Vladimir Kozlov <[email protected]> wrote:
>> AOT adapters code caching and loading is guarded by these methods not by
>> flag.
>>
>> Setting AOTAdapterCaching to false on failure is simple indication that
>> adapter caching is switched off for someone who will look on final state of
>> flag.
>
> I added `log_info()` to `exit_vm_on_*_failure()` methods to produce
> notification when AbortVMOnAOTCodeFailure flag is off (default value).
The naming (`exit_vm_on_load_failure` and `exit_vm_on_store_failure`) still
look confusing to me. By default, they disable `AOTAdapterCaching` and issue a
message, but the name strongly suggests that execution halts there:
if (!open_cache(is_dumping, is_using)) {
if (is_using) {
exit_vm_on_load_failure();
} else {
exit_vm_on_store_failure();
}
return;
}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24740#discussion_r2069613390
