On Wed, 7 May 2025 22:59:04 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> We should always exclude `doc-files` and `snippet-files` when compiling java >> code. To generalize this, exclude all `*-files` directories. >> >> (The usage of EXCLUDES and EXCLUDE_FILES is a bit weird. In essence, >> EXCLUDE_FILES prepends a `%` wildchar match to the filenames given, which we >> use here, while EXCLUDES matches only strict directory names in the path. >> These should probably be clarified/redesigned for more intuitive exclusion.) > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Get rid of looped eval Marked as reviewed by erikj (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/24449#pullrequestreview-2825780015