On Mon, 11 Aug 2025 09:24:27 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed makefiles
>
> make/RunTests.gmk line 882:
>
>> 880: ifneq ($$(JTREG_JVMTI_STRESS_AGENT), )
>> 881: AGENT :=
>> $$(LIBRARY_PREFIX)JvmtiStressAgent$$(SHARED_LIBRARY_SUFFIX)=$$(JTREG_JVMTI_STRESS_AGENT)
>> 882: $1_JTREG_BASIC_OPTIONS +=
>> -javaoption:'-agentpath:${TEST_IMAGE_DIR}/hotspot/jtreg/native/$${AGENT}'
>
> Suggestion:
>
> $1_JTREG_BASIC_OPTIONS +=
> -javaoption:'-agentpath:$(TEST_IMAGE_DIR)/hotspot/jtreg/native/$$(AGENT)'
Also, this line looks quite long. Can you check that it does not pass 80
characters? (Can't tell on github reviews...)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26360#discussion_r2266132846
