On Tue, 19 Aug 2025 14:48:34 GMT, Volkan Yazici <[email protected]> wrote:
>> In Devkit, removes `ppc64`/`ppc64be`, which is superseded by `ppc64le`,
>> fixes Fedora repository links, and bumps the `LATEST_ARCHIVED_OS_VERSION` to
>> 36.
>
> Volkan Yazici has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Run `update-build-docs`
> - Revert `ppc64be` removal
make/devkit/Tools.gmk line 76:
> 74: endif
> 75: ifeq ($(ARCH), riscv64)
> 76: ifeq ($(filter 36 37, $(BASE_OS_VERSION)), )
The test and the error message does not match up.
make/devkit/Tools.gmk line 88:
> 86: endif
> 87: ifeq ($(ARCH), armhfp)
> 88: ifneq ($(BASE_OS_VERSION),36)
Suggestion:
ifneq ($(BASE_OS_VERSION), 36)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26821#discussion_r2287140943
PR Review Comment: https://git.openjdk.org/jdk/pull/26821#discussion_r2287144658
