On Wed, 27 Aug 2025 17:02:39 GMT, Erik Joelsson <[email protected]> wrote:
>> Francesco Andreuzzi has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - stuff >> - nn > > make/scripts/update_pch.sh line 101: > >> 99: mv "$PRECOMPILED_HPP.tmp" "$PRECOMPILED_HPP" >> 100: >> 101: java /jdk/test/hotspot/jtreg/sources/SortIncludes.java --update >> /jdk/src/hotspot/share/precompiled > > This looks like an absolute path. Does that actually work? My bad, fixed in ead2c779b4481efb06b519924b5e56eeecad3674 That path is only valid in the Docker image where I tested the script, it shouldn't have been there. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26681#discussion_r2304908332
