On Fri, 5 Sep 2025 08:55:26 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> When calling ExecuteWithLog with a redirection (using > or, possibly, <), >> the entire command needs to be executed in a subshell, that is, inside a >> pair of parentheses. This is the callers obligation to ensure, but we have >> proven multiple times that this is hard to keep in mind, and we got several >> cases of race conditions due to missing this. >> >> This PR changes the implementation of ExecuteWithLog so it checks if the >> command line contains redirection, and automatically add the subshell >> parentheses in that case. The alternative would have been to always execute >> in a subshell, but that would have been very expensive on Windows. > > Magnus Ihse Bursie has updated the pull request incrementally with two > additional commits since the last revision: > > - Break all lines to fit in 80 chars > - Break long lines Marked as reviewed by erikj (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/27096#pullrequestreview-3189211393
