On Thu, 14 Aug 2025 13:31:51 GMT, Kim Barrett <[email protected]> wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains two >> additional commits since the last revision: >> >> - Merge branch 'master' into no-gtest-ehsc >> - 8365231: Don't build gtest with /EHsc > > make/hotspot/lib/CompileGtest.gmk line 112: > >> 110: DISABLED_WARNINGS_clang_test_g1ServiceThread.cpp := >> delete-abstract-non-virtual-dtor, \ >> 111: DISABLED_WARNINGS_clang_test_logDecorations.cpp := >> missing-field-initializers, \ >> 112: DISABLED_WARNINGS_microsoft := $(DISABLED_WARNINGS_microsoft) 4530, >> \ > > How widespread are these warnings? I expect such a warning from > jfr/test_networkUtilization.cpp, > but not anywhere else. Could the disable of this warning be narrowed > accordingly? I checked. It is for all `test_*.cpp` files, due to gtest include files. So we need to to this broad spectrum disable. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26721#discussion_r2332407984
