> According to > https://github.com/openjdk/jdk/pull/26661#issuecomment-3162014034, we should > not build gtest with `/EHsc`. > > I can honestly say I don't fully understand the consequences of this change, > but at least it passes building and testing on Oracle CI. And it does seem to > make sense that we build the gtest version of libjvm as close as possible to > the real version. For libgtest I just thought it was prudent to keep the > flags in sync with how we build libjvm. This might not be the correct > decision. > > I have not tested how or if this affects the ability for gtest to handle bugs > or crashes in the JVM, nor do I really have any idea about any such > consequences. This PR is opened more to start a discussion than with the > intention of just integrating this.
Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into no-gtest-ehsc - Merge branch 'master' into no-gtest-ehsc - 8365231: Don't build gtest with /EHsc ------------- Changes: - all: https://git.openjdk.org/jdk/pull/26721/files - new: https://git.openjdk.org/jdk/pull/26721/files/f2127bb3..3c2f340c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=26721&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26721&range=01-02 Stats: 228 lines in 12 files changed: 43 ins; 163 del; 22 mod Patch: https://git.openjdk.org/jdk/pull/26721.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/26721/head:pull/26721 PR: https://git.openjdk.org/jdk/pull/26721
