On Thu, 11 Sep 2025 00:39:43 GMT, Jiangli Zhou <[email protected]> wrote:
>> @AlanBateman @jianglizhou Now that Erik has approved the build >> functionality, I'd appreciate if anyone of you could approve as well, then I >> can finally integrate this. > >> @magicus I'll take a look today. > > Hi @magicus I looked at your changes and focused on the launcher changes. I > only looked quickly of the build changes, I think @erikj79's review is > sufficient. For launcher changes, my main question is Windows platform > support (for static JDK) and testing. The rest of the comments are minor. I just realized that the testing I kicked off (tier1-5 on our internal CI) does not include running tests using the static-jdk. @jianglizhou Do you have any recommendation to the easiest way to use the static-jdk for testing? ------------- PR Comment: https://git.openjdk.org/jdk/pull/24380#issuecomment-3280273927
