On Fri, 12 Sep 2025 13:03:01 GMT, Erik Joelsson <[email protected]> wrote:
>> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unnecessary CFLAGS save and restore > > make/autoconf/flags-other.m4 line 128: > >> 126: saved_cc="$CC" >> 127: CFLAGS="$CFLAGS -march=armv8-a+sve >> $CFLAGS_WARNINGS_ARE_ERRORS ARG_ARGUMENT" >> 128: CC="$ARG_PREFIX[CC]" > > You shouldn't need to save `CC` and use a custom one here. `CC` should be the > target compiler already. Thanks for the correction. The unnecessary ARG_PREFIX has been removed. > make/autoconf/flags-other.m4 line 140: > >> 138: [AVAILABLE=false] >> 139: ) >> 140: AC_MSG_RESULT([$AVAILABLE]) > > This will now print true/false instead of yes/no, which will look a bit > weird. It's a consequence of us preferring `true/false` to express booleans > internally. I think I would inline the call to `AC_MSG_RESULT` in each of the > branches of `AC_COMPILE_IFELSE` to work around this. Okey, the `AC_MSG_RESULT` call has been moved to the branches of `AC_COMPILE_IFELSE`. > make/autoconf/flags.m4 line 380: > >> 378: # for SVE. Set SVE_CFLAGS to -march=armv8-a+sve if it does. >> 379: # ACLE and this flag are required to build the aarch64 SVE related >> functions >> 380: # in libvectormath. > > I think you misunderstood me here, I meant move it to the top of the macro > declaration, not the call. I think it makes more sense to document it where > it's defined. Sorry for the misunderstood. The comment has been moved to the top of macro, ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27073#discussion_r2344310975 PR Review Comment: https://git.openjdk.org/jdk/pull/27073#discussion_r2344321261 PR Review Comment: https://git.openjdk.org/jdk/pull/27073#discussion_r2344306576
