On Fri, 7 Nov 2025 13:37:57 GMT, Kerem Kat <[email protected]> wrote:
> Include top-level folder name in the source root, to help distinguishing
> different vscode instances and include the build configuration name in the
> "Build artifacts" virtual folder name in vscode, in the generated workspace
> file from `make vscode-project`.
>
> <img width="400" height="353" alt="image"
> src="https://github.com/user-attachments/assets/5202aae9-19ff-472e-b966-46419c921370";
> />
I think this change makes sense, but it would be good to get input from other
VS Code users.
make/ide/vscode/hotspot/CreateVSCodeProject.gmk line 88:
> 86: $(call RelativePath,$(OUTPUTDIR),$(TOPDIR)))))!g' \
> 87: -e 's!{{TOPDIR_BASE}}!$(notdir $(TOPDIR))!g' \
> 88: -e 's!{{OUTPUT_BASE}}!$(notdir $(OUTPUTDIR))!g' \
These lines aren't lining up with the rest. Please see
https://openjdk.org/groups/build/doc/code-conventions.html for details on build
system code conventions.
-------------
PR Review: https://git.openjdk.org/jdk/pull/28194#pullrequestreview-3434077079
PR Review Comment: https://git.openjdk.org/jdk/pull/28194#discussion_r2503668068
