On Tue, 11 Nov 2025 16:53:02 GMT, Henry Jen <[email protected]> wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 620:
>>
>>> 618: // silently ignore and fall through to version mismatch
>>> 619: targetRelease = "missing";
>>> 620: }
>>
>> Instead of claiming that the `release.txt` file contains the string
>> "missing", we could just throw a specific exception to that effect, no?
>> Something along the lines of:
>>
>>
>> Error: java.base module specified on the module path does not contain
>> critical resource needed for verifying compatibility to the current runtime
>> with version <currrent-version>
>
> Sure we can. I do want to keep a message consistent and softer as this can
> happen to releases before this get merged. Thought 'missing' is a little
> better than 'N/A' which is more likely in a release.txt.
Actually, if we just leave it blank, that message still works in all
translation, I think.
src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink_ja.properties
81:err.jlink.version.mismatch=jlinkバージョン{0}がターゲットのjava.baseバージョン{1}と一致しません
src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink_zh_CN.properties
81:err.jlink.version.mismatch=jlink 版本 {0} 与目标 java.base 版本 {1} 不匹配
src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink_de.properties
81:err.jlink.version.mismatch=jlink-Version {0} stimmt nicht mit
Ziel-java.base-Version {1} überein
src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties
133:err.jlink.version.mismatch=jlink build {0} does not match target java.base
build {1}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28155#discussion_r2515029024
