On Tue, 25 Nov 2025 13:56:34 GMT, Erik Joelsson <[email protected]> wrote:

>> Galder Zamarreño has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Fix line breaks
>
> doc/building.html line 547:
> 
>> 545: comes bundled with Xcode, so it needs to be installed separately. This 
>> can
>> 546: either be done via the Xcode's Settings/Components UI, or in the 
>> command line
>> 547: calling <code>xcodebuild -downloadComponent metalToolchain</code>.</p>
> 
> When I checkout this branch and run `make update-build-docs`, the line breaks 
> here are done differently. It would be good to not introduce future diffs 
> when the html files are regenerated next time.
> 
> Suggestion:
> 
> <p>Starting with Xcode 26, introduced in macOS 26, the Metal toolchain
> no longer comes bundled with Xcode, so it needs to be installed
> separately. This can either be done via the Xcode's Settings/Components
> UI, or in the command line calling
> <code>xcodebuild -downloadComponent metalToolchain</code>.</p>

@erikj79 Ran the target and pushed the changes

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28489#discussion_r2568089159

Reply via email to