On Mon, 5 Jan 2026 17:20:29 GMT, Weijun Wang <[email protected]> wrote:

>> Rewrite the native calls with FFM.
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   must have username; more comments

src/jdk.security.auth/share/classes/com/sun/security/auth/module/UnixSystem.java
 line 88:

> 86:             = (ValueLayout) LINKER.canonicalLayouts().get("size_t");
> 87: 
> 88:     private static final StructLayout capturedStateLayout = 
> Linker.Option.captureStateLayout();

Would it be a good idea to use capitalized names for immutable static fields in 
all places in the class? E.g., `CAPTURED_STATE_LAYOUT` here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28931#discussion_r2667524583

Reply via email to