On Thu, 8 Jan 2026 06:02:34 GMT, Jaikiran Pai <[email protected]> wrote:
>> test/failure_handler/src/share/classes/jdk/test/failurehandler/HtmlPage.java >> line 65: >> >>> 63: this.writer = new PrintWriter(fileWriter, true); >>> 64: createScriptFile(dir); >>> 65: createStyleSheetFile(dir); >> >> Won't this create/overwrite the files each time one of the artifact pages >> (cores.html, processes.html etc) get created? Don't we just want to create >> one copy of these files. > > It will yes. In an initial version I had a check to only create those files > if not already present in that directory. I removed that check because each > time I updated the script content in the java source code, I had to then > manually delete these files from the local JTwork directory hierarchy, for > that new content to be written to them in the subsequent jtreg run. > > With this code now stabilized, I think that check can be introduced back. I > will update this PR shortly with that change. Done, I've updated the PR to add a check for the file existence. This change continues to work fine in my local testing. I'll run another round of CI test with this change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29106#discussion_r2671098077
