Can I please get a review of this jtreg failure handler code change which 
addresses the issue noted in https://bugs.openjdk.org/browse/JDK-8374181?

The implementation in this failure handler generates a cores.html for each core 
file that was generated during the test run. The bug here is that instead of 
creating multiple "sections", one each for the core file, within an `<html>` 
element, it ends up creating multiple `<html>` elements one after another 
within the same HTML file. This causes the HTML rendering to go wrong.

The commit in this PR addresses that issue by creating one section, under the 
`<html>` element, for each core file.

I've verified that with this change, the cores.html is now correctly structured 
and rendered.

-------------

Commit messages:
 - 8374181: failure_handler: The cores.html file is formatted incorrectly and 
so hides the core dump information

Changes: https://git.openjdk.org/jdk/pull/29150/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29150&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8374181
  Stats: 23 lines in 1 file changed: 12 ins; 1 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/29150.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/29150/head:pull/29150

PR: https://git.openjdk.org/jdk/pull/29150

Reply via email to