On Mon, 19 Jan 2026 07:04:36 GMT, Julian Waters <[email protected]> wrote:
>> --with-native-debug-symbols-level was added some time ago to allow selecting
>> the level of debugging information created for compiled binaries. The
>> UTIL_ARG_WITH utility that the option implementation uses has several
>> features that can be used to simplify handling of this option, so that is
>> done in this change.
>
> Julian Waters has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove -g and don't pass the flag at all if option is not given
> flags-cflags.m4
make/autoconf/flags-cflags.m4 line 85:
> 83: ],
> 84: IF_NOT_GIVEN: [
> 85: NATIVE_DEBUG_SYMBOLS_LEVEL=""
I would have thought this needs to be `-g`, so we pass `-g` when
`--native-debug-symbols-level` is not specified?
make/autoconf/flags-cflags.m4 line 113:
> 111:
> 112: # Debug info level should follow the debug format to be effective.
> 113: CFLAGS_DEBUG_SYMBOLS="-gdwarf-4 ${NATIVE_DEBUG_SYMBOLS_LEVEL}"
Yeah, from this definition, it is not a "level", it is "flags". So name it e.g.
`NATIVE_DEBUG_SYMBOLS_FLAGS` or some such?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29214#discussion_r2703626427
PR Review Comment: https://git.openjdk.org/jdk/pull/29214#discussion_r2703629603
