On Wed, 21 Jan 2026 03:14:39 GMT, SendaoYan <[email protected]> wrote:
>> Hi all, >> >> The sctp tests need libsctp.so.1 to be installed, otherwise those tests will >> report skipped. Seems that there is no help information to descript how to >> run those tests. I think it's meaningful to add help information how to run >> those tests. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > 1. Update apt/dnf description; 2. Add "sudo modprobe sctp" after apt install doc/testing.html line 629: > 627: by default in popular Linux distributions. Without this library, > 628: the SCTP tests will be skipped. If you want to enable the SCTP tests, > 629: you should install the SCTP library before run the tests.</p> These line lengths look uneven. The html generator tool would not generate it like that. If I run `make update-build-docs` I get a diff on these lines. Please make sure the html files you are committing are exactly what the tool would generate to avoid creating diffs for the next person editing these files. doc/testing.md line 649: > 647: by default in popular Linux distributions. Without this library, > 648: the SCTP tests will be skipped. If you want to enable the SCTP tests, > 649: you should install the SCTP library before run the tests. Suggestion: you should install the SCTP library before running the tests. Also please fix line breaks so line lengths are uniform and match the rest of the file. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29320#discussion_r2712838402 PR Review Comment: https://git.openjdk.org/jdk/pull/29320#discussion_r2712825228
