On Tue, 3 Feb 2026 07:22:27 GMT, Kim Barrett <[email protected]> wrote:
>> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changes after comments from Erik and Kim > > There is some overlap in purpose between the build system changes here and > those in my proposed change for JDK-8332189 > (https://github.com/openjdk/jdk/pull/29497). > While this change is more general purpose, it's not obvious to me that it > would actually get applied anywhere other than to HotSpot. Being selective > about the scope for adding options has both good and bad points. That applies > to both approaches. My feeling is the bad outweighs the good here. I don't > think I like the idea of having ghettos within HotSpot where different warning > options are applied. We already have some of that with per-file disabling of > warning, which we don't seem to be making much progress on reducing, even for > HotSpot. > > I've not made any attempt to seriously review the new infrastructure here. I'd > prefer to leave that to people with a better understanding of makefile > programming and of our build system. I am not opposing your (@kimbarrett ) changes to warning flags and that is a great option if you can fix changes in all of hotspot. My changes are great when incrementally hardening the flags. I think my feature is really needed. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29523#issuecomment-3842281488
