On Tue, 10 Mar 2026 18:16:34 GMT, Roger Riggs <[email protected]> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> attempt a different fix for the MacOS kernel-closes-CLOEXEC-fds-too-early >> problem > > src/java.base/unix/native/libjava/childproc.c line 435: > >> 433: (closeSafely(p->childenv[0]) == -1) || >> 434: (closeSafely(p->childenv[1]) == -1) || >> 435: (closeSafely(p->fail[0]) == -1)) > > The errno sent by WhyJohnnyCantExec will be meaningless if any of these are > true. > It would useful debugging info to insert some kind of identifying code in the > upper bits of errno for each of the `goto WhyCan'tJohnnyExec`. That is a neat idea. I had vaguely something similar in mind for a follow-up RFE, but seeing that analysis in this PR is so much fun I will try and add a small version of this here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29939#discussion_r2916291306
