On Mon, 20 Apr 2026 06:52:33 GMT, Matthias Baesken <[email protected]> wrote:

>> src/hotspot/share/oops/metadata.cpp line 38:
>> 
>>> 36:   NOT_PRODUCT(_valid = 0;)
>>> 37: }
>>> 38: 
>> 
>> We need for this to work with PRODUCT builds also. It's unclear to me why 
>> _valid was initially introduced, and why only for NOT_PRODUCT builds.
>
> okay so should I remove the NOT_PRODUCT ?

> We need for this to work with PRODUCT builds also. It's unclear to me why 
> _valid was initially introduced, and why only for NOT_PRODUCT builds.

Seems it is used in some debug code, at least removing it breaks the fastdebug 
build.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30771#discussion_r3118273579

Reply via email to