On Fri, 8 May 2026 10:27:49 GMT, Thomas Schatzl <[email protected]> wrote:
>> Hi all, >> >> please review this change that allows building of the JDK without Serial >> GC enabled. >> >> There were some hardcoded entries for -XX:+UseSerialGC in the makefiles, and >> one of the gtests is serial gc specific and needed to be moved. Noticed >> during tests with JEP 523: Make G1 the Default Garbage Collector in All >> Environments. >> >> I opted to a different fix than suggested in the CR, instead of wholesale >> ignoring unrecognized options, only add serial gc to the relevant options if >> the feature is enabled in the build. The change seems small enough. >> >> Tested manually with and without `--with-jvm-features=-serialgc`, both image >> building and running the test works in both cases (being skipped/not found >> if serial gc has not been enabled). >> >> Other testing: gha >> >> Thanks, >> Thomas >> >> >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Thomas Schatzl has updated the pull request incrementally with one additional > commit since the last revision: > > * use the default collector, do not force Serial GC for anything 👍 On this change. Very nice that we can do this without degradation to the build times. _Should the issue title reflect that this is now just "use the default GC when building"?_ ------------- Marked as reviewed by aboldtch (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/31049#pullrequestreview-4251705962
