On Fri, 29 May 2026 20:48:48 GMT, Mikael Vidstedt <[email protected]> wrote:
>> make/devkit/Sysroot.gmk line 137:
>>
>>> 135: endif
>>> 136: ls $(DOWNLOAD_RPMS)/*.rpm > /dev/null 2>&1 || \
>>> 137: { echo "Failed to download rpms"; exit 1; }
>>
>> Curious about this construct. What situation are you trying to handle? If
>> any rpms are already present, you silently don't download anything but still
>> update the touch file. I would think deleting the touch file should trigger
>> a full new download, or am I missing something?
>
> This is a remnant from before I switched to dnf for downloading the rpms and
> was getting tired of running into wget not downloading anything but the build
> still proceeded. dnf does the checking so it's no longer needed.
>
> Removed.
I probably wasn't clear. I was mainly referring to the ifeq that checks for
RPMs being present. That seems unnecessary with the touch file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31303#discussion_r3334611725
