On Wed, 6 May 2026 08:14:18 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Andrew Haley has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 111 commits: >> >> - Merge branch 'master' into JDK-8134940 >> - Review comments >> - Review comments >> - Add FrameMap::last_fpu_reg() >> - Review comments >> - Review comments >> - Review comments >> - Merge branch 'JDK-8134940' of https://github.com/theRealAph/jdk into >> JDK-8134940 >> - More >> - Merge branch 'JDK-8134940' of https://github.com/theRealAph/jdk into >> JDK-8134940 >> - ... and 101 more: https://git.openjdk.org/jdk/compare/3e1d0b8e...4610777b > > src/hotspot/cpu/arm/c1_MacroAssembler_arm.cpp line 259: > >> 257: >> https://www.researchgate.net/publication/2683298_A_Collection_of_Selected_Pseudorandom_Number_Generators_With_Linear_Structures >> */ >> 258: mov_slow(temp, 69069); >> 259: mul(state, state, temp); > > `+1` is missing in this LGC? AArch64 has it. You're right. Entacher allows either. The disadvantage of eliding `+1` is that if (because of some unknown bug) `state` should ever become zero, it'll be zero forever. To the best of my knowledge this never happens,so adding 1 is a defence-in-depth thing. I'd appreciate your opinion on this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3357223348
