On Sat, 6 Jun 2026 16:18:10 GMT, Boris Ulasevich <[email protected]> wrote:

> The 
> [test/hotspot/jtreg/runtime/jni/critical/libSuspendInCritical.cpp](https://github.com/openjdk/jdk/pull/30936/changes#diff-137899820d5ad5d36c91c879aa09a9678112d4be6718ba8e64ebfe1a20f6dda3)
>  library operates with `jlong` native_counter. 32-bit ARM lacks native 8-byte 
> atomic instructions, so GCC emits calls to 
> __atomic_load_8/__atomic_fetch_add_8 from libatomic, which is not linked, 
> causing a build failure.
> 
> The issue is fixed by adding -latomic link flag for the library into 
> JtregNativeHotspot.gmk.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Looks okay. We used to link with `-latomic` for 32-bit platforms wholesale, 
IIRC. So if we get more tests like these, maybe we will drop the compilation 
unit filter. But it is fine as it is now.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/31411#pullrequestreview-4447227322

Reply via email to