On Mon, 8 Jun 2026 09:43:32 GMT, Manuel Hässig <[email protected]> wrote:

>> This PR introduces a `.git-blame-ignore-revs` file to the JDK repo root 
>> directory. This file contains a list of git commit hashes that should be 
>> excluded from consideration when running [git-blame 
>> (1)](https://git-scm.com/docs/git-blame). This file is [automatically 
>> honored by Github (with an escape 
>> hatch)](https://docs.github.com/en/repositories/working-with-files/using-files/viewing-and-understanding-files#ignore-commits-in-the-blame-view).
>>  Locally, however, every developer that wants to make use of this needs to 
>> either configure it using [`git config 
>> blame.ignoreRevsFile`](https://git-scm.com/docs/git-blame#Documentation/git-blame.txt-blameignoreRevsFile)
>>  or specify it on the command line using [`git blame 
>> --ignore-revs-file`](https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-filefile).
>> 
>> Initially, `.git-blame-ignore-revs` contains the commits associated with the 
>> refactoring from `NULL` to `nullptr` in hotspot. Personally, it has already 
>> happened to me multiple times that I ran `git blame` only to find one of 
>> those commits. This could of course be solved with more complicated 
>> `git`invocations. Maintaining this file of ignored revisions, however, gives 
>> us a tool to alleviate this papercut from the already arduous process of 
>> tracking down failures in the JDK.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Manuel Hässig has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix typo

Marked as reviewed by erikj (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/31402#pullrequestreview-4455652750

Reply via email to