On Thu, 4 Jun 2026 10:07:40 GMT, Ivan Bereziuk <[email protected]> wrote:

>> Please review this test enhancement.
>> Implemented the padding-tolerant Unified Logging assertions.
>> A bunch of  Unified Logging assertions do not account for possible extra 
>> padding in the `[<tags>]` section.
>> 
>> Changed short-tag UL assertions from rigid `shouldContain(...)` to 
>> `shouldMatch(...)` with patterns like:
>> 
>> \[class,load *\] ...
>> 
>> 
>> Covered short categories including `class,load`, `nmt`, `pagesize`, `aot`, 
>> `jni`, `cds`, and `trimnative`. I left remaining `shouldContain()` hits 
>> alone where the tag set is long enough - `class,resolve`,  `verification`, 
>> `gc,heap,coops`, etc.).
>> 
>> Also updated a couple of existing rigid `shouldMatch()` UL regexes for the 
>> same padding issue.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Ivan Bereziuk has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   tolerate extra space in one [class,preview]. Trim redundant .\* in few 
> other checks.

Marked as reviewed by dholmes (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/31338#pullrequestreview-4463946117

Reply via email to