On Wed, 10 Jun 2026 19:40:09 GMT, Chen Liang <[email protected]> wrote:

>> David Simms has updated the pull request with a new target base due to a 
>> merge or a rebase. The pull request now contains 2798 commits:
>> 
>>  - Merge remote-tracking branch 'valhalla/lworld' into 
>> jep401_sub_review_8317277
>>  - 8386239: [lworld] Update jdk/java/util/Arrays/ArraysEqCmpTest.java
>>    
>>    Reviewed-by: liach
>>  - 8386242: [lworld] Simplify and clarify StrictProcessor
>>    
>>    Reviewed-by: dsimms
>>  - 8386140: [lworld] FieldReflector using wrong Class argument
>>    
>>    Reviewed-by: alanb, dsimms
>>  - 8386216: [lworld] Rollback meaningless diff in EventClassBuilder
>>    
>>    Reviewed-by: dsimms
>>  - 8385170: [lworld] Serialization spec needs to allow abstract value 
>> classes like Number
>>    
>>    Reviewed-by: liach
>>  - 8385980: [lworld] Standardize pattern for preview value class generation
>>    
>>    Reviewed-by: liach
>>  - 8386086: [lworld] 
>> sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java should be 
>> removed from problem list
>>    
>>    Reviewed-by: liach, dcubed
>>  - Merge
>>    
>>    Merge jdk-28+1
>>  - 8386090: [lworld] Redundant test changes in lworld versus mainline
>>    
>>    Reviewed-by: vromero
>>  - ... and 2788 more: https://git.openjdk.org/jdk/compare/92298786...1b636ee4
>
> src/java.compiler/share/classes/javax/lang/model/element/Modifier.java line 
> 177:
> 
>> 175:      * @since Valhalla
>> 176:      */
>> 177:     @PreviewFeature(feature=PreviewFeature.Feature.LANGUAGE_MODEL, 
>> reflective=true)
> 
> Suggestion:
> 
>     @PreviewFeature(feature=PreviewFeature.Feature.VALUE_OBJECTS, 
> reflective=true)

We probably need to rename LANGUAGE_MODEL to something like PREVIEW_METADATA in 
a separate RFE.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31121#discussion_r3391066569

Reply via email to