On Fri, 5 Jun 2026 08:44:02 GMT, 0108maeda <[email protected]> wrote:

> **Overview:**
> 
> This test primarily focuses on the verifying the SOURCE value in the Oracle 
> provided OpenJDK build. In the cases except these, in order for the SOURCE 
> value to be more flexible, there have been process added where the SOURCE 
> value is empty.
> 
> **Confirmation of the program after the fix:**
> 
> After Fix CheckReleaseFile.java was verified against various SOURCE values, 
> including both empty and non-empty cases, to ensure that it processes them 
> correctly. The verification was performed using both internally built OpenJDK 
>  and Oracle's OpenJDK build.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Thanks for your review.
I thought that empty SOURCE only means lack of .git. But now I understand that 
actually, regardless of .git existance, there is case of empty SOURCE, and it 
should be detected as failed.

Current test has process about regular expressions, and this process detects 
empty SOURCE as not meet reqular expressions. While it is true, rather than 
that, it could shows a specific case that .git does not exist. Therefore I 
think this test still has necessity adding some process for empty SOURCE. 
Considering that your review, in particular this test needs exception to 
announce that.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31399#issuecomment-4679107174

Reply via email to