On Thu, 11 Jun 2026 11:27:39 GMT, Alan Bateman <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2798 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> jep401_sub_review_8317279 >> - 8386239: [lworld] Update jdk/java/util/Arrays/ArraysEqCmpTest.java >> >> Reviewed-by: liach >> - 8386242: [lworld] Simplify and clarify StrictProcessor >> >> Reviewed-by: dsimms >> - 8386140: [lworld] FieldReflector using wrong Class argument >> >> Reviewed-by: alanb, dsimms >> - 8386216: [lworld] Rollback meaningless diff in EventClassBuilder >> >> Reviewed-by: dsimms >> - 8385170: [lworld] Serialization spec needs to allow abstract value >> classes like Number >> >> Reviewed-by: liach >> - 8385980: [lworld] Standardize pattern for preview value class generation >> >> Reviewed-by: liach >> - 8386086: [lworld] >> sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java should be >> removed from problem list >> >> Reviewed-by: liach, dcubed >> - Merge >> >> Merge jdk-28+1 >> - 8386090: [lworld] Redundant test changes in lworld versus mainline >> >> Reviewed-by: vromero >> - ... and 2788 more: https://git.openjdk.org/jdk/compare/92298786...4d6d2888 > > test/jdk/java/lang/invoke/defineHiddenClass/BasicTest.java line 310: > >> 308: assertTrue(hc.isHidden()); >> 309: // ACC_SUPER bit may appear spuriously if preview is enabled >> 310: assertEquals(hc.getModifiers() & (~ACC_SUPER), (ACC_PUBLIC | >> accessFlags)); > > Chen - do you remember why this comment was added? The method source > emptyClasses doesn't have any value classes so I expect IDENTITY to be set > for empty classes that aren't interfaces when preview is enabled. Asking > about "spuriously" suggests something random is going on. I think this is just bad wording from my part - this should really be `assertEquals(hc.getModifiers(), ACC_PUBLIC | (Number.class.isValue() ? ACC_IDENTITY : 0) | accessFlags);` so we don't need to query `PreviewFeatures`. > test/jdk/java/util/Arrays/SetAllTest.java line 38: > >> 36: import java.util.function.IntUnaryOperator; >> 37: >> 38: import jdk.test.lib.valueclass.AsValueClass; > > Which test runs use the ValueClassPlugin with --enable-preview to generate > VClass as a value class? There is `valhalla_adopted` group in `test/jdk/TEST.groups`, also `hotspot_valhalla_adopted` in `test/hotspot/jtreg/TEST.groups`. These groups are run with the ValueClassPlugin in one of Oracle's CI configurations. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3395845979 PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3395833089
