Re: RFR: 8317279: Standard library implementation of value classes and objects [v4]

[Chen Liang]

On Fri, 12 Jun 2026 15:08:58 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/Object.java line 523:
>> 
>>> 521:      *      <div class="preview-comment">
>>> 522:      *          If this object is a {@linkplain 
>>> java.util.Objects#hasIdentity value object},
>>> 523:      *          it does does not have a monitor, an {@code 
>>> IllegalMonitorStateException} is thrown.
>> 
>> Suggestion:
>> 
>>      *          it does not have a monitor, an {@code 
>> IllegalMonitorStateException} is thrown.
>
> This is also the only preview note that is placed in an `@apiNote` tag. I 
> think it should be moved up to the main description of the doc comment for 
> consistency.

Thanks to both of you, incorporated into 
https://github.com/openjdk/valhalla/pull/2536

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3404607822