On Fri, 26 Jun 2026 22:12:37 GMT, Chris Plummer <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use print_error()
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebuggerLocal.java
> line 326:
>
>> 324: if ((debugger instanceof LinuxAARCH64DebuggerLocal d) &&
>> d.isPACEnabled()) {
>> 325:
>> ((MachineDescriptionAArch64)d.getMachineDescription()).enablePAC();
>> 326: }
>
> Is there a better place for this? Maybe closer to the creation of the
> MachienDescriptorAArch54?
Yes, we can move it to near the insantiate of `MachineDescriptorAArch64` in
case of live attach, but I think it is better to place it in similar place for
core attaching for consistency. We have to get the status of PAC from coredump
after attaching in case of the core because we have to consider to analyze
coredump produced by PAC-enabled machine on PAC-disabled machine.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31669#discussion_r3485086686
