On Fri, 26 Jun 2026 06:40:49 GMT, David Simms <[email protected]> wrote:
>> This is a "*sub-review pull request*" for the first >> [preview](https://openjdk.org/jeps/12) of [JEP 401: Value Classes and >> Objects](https://openjdk.org/jeps/401), specifically >> [JDK-8317279](https://bugs.openjdk.org/browse/JDK-8317279): Standard library >> implementation of value classes and objects >> >>> [!NOTE] >>> This pull request and the other sub-review pull requests listed below are >>> based on the "*master pull request*" >>> (https://github.com/openjdk/jdk/pull/31120). It contains the same full set >>> of code changes as the "*master pull request*" to preserve the full >>> implementation context; the language compiler, JVM, and standard library >>> changes are intertwined. This separate pull requests exist only to >>> subdivide the review and related discussion by area. >> >> Other areas for review: >> >> - [JDK-8317277](https://bugs.openjdk.org/browse/JDK-8317277): Java language >> implementation of value classes and objects >> - https://github.com/openjdk/jdk/pull/31121 >> - [JDK-8317278](https://bugs.openjdk.org/browse/JDK-8317278): JVM >> implementation of value classes and objects >> - https://github.com/openjdk/jdk/pull/31122 >> >> Code changes resulting from the review process should be made in >> [`valhalla/lworld`](https://github.com/openjdk/valhalla/). >> >> `valhalla/lworld` is currently updated from `jdk/master` whenever a weekly >> [`jdk` tag](https://github.com/openjdk/jdk/tags) is created. At that time, >> code changes from `valhalla/lworld` will be propagated to the master pull >> request and to all sub-review pull requests, including this one. >> >> Ultimately, review sign-off will be recorded on the "*master pull request*", >> and this pull request will be closed without integration. >> >> This pull request has a large code surface area and often conflicts with >> `jdk/master` on a daily basis. Refer to >> [`valhalla/lworld`](https://github.com/openjdk/valhalla/) for the latest >> state of the project code, keeping in mind that it may lag several days >> behind `jdk/master`. Both repositories may be needed as references during >> review. >> >> # PR implementation description >> >> Here's a high-level overview of what's included here. >> >> ### Core object behaviors >> >> Introduced `Objects` methods to test for identity and `IdentityException` for >> test failures; revised definitions of `==` and `identityHashCode` to work on >> the >> fields of value objects. >> >> - `src/java.base/share/classes/java/lang` >> - `src/java.base/share/classes/java/util` >> - `src/java.base/share/classes/java/lang/runtime` >> - ... > > David Simms has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 2859 commits: > > - Merge branch '8317277' into jep401_sub_review_8317279 > - Merge remote-tracking branch 'valhalla/lworld' into 8317277 > - Merge > > Merge jdk-28+4 > - 8386963: [lworld] Improve the exception message from Object > synchronization methods on value objects > > Reviewed-by: dholmes, alanb > - 8387300: [lworld] Minor review comments in javac > > Reviewed-by: vromero > - 8387192: [lworld] Review comment drop for core libs > > Reviewed-by: jvernee, vromero > - 8386999: [lworld] C2: assert(is_dead_loop_safe()) failed: shouldn't be > cleared yet > > Reviewed-by: qamai, vlivanov > - 8386787: [lworld] > compiler/valhalla/inlinetypes/TestValueConstruction.java#StressIncrementalInliningDontInlineMyAbstractInit > timed out > > Reviewed-by: phubner, chagedorn > - 8386995: [lworld] Duplicate value classes are a preview feature warning > > Reviewed-by: alanb, vromero > - 8383389: [lworld] Augment AOTMapLogger::print_oop_details to support flat > arrays with oops > > Reviewed-by: iklam, fparain > - ... and 2849 more: https://git.openjdk.org/jdk/compare/193de1b1...cdbe55a9 test/jdk/java/io/Serializable/valueObjects/SimpleValueGraphs.java line 79: > 77: @ParameterizedTest > 78: @MethodSource("valueObjects") > 79: public void roundTrip(Object expected) throws Exception { I think this test class and this test method in particular with need some attention. The summary of this test says "Serialize and deserialize value objects". This `roundTrip()` method sources its param from "valueObjects" method. The `valueObjects()` method a few lines above constructs instances of `SimpleValue` class. `SimpleValue` class (some lines below) is declared as: public static class SimpleValue implements Serializable It's an identity class. So, unless I'm missing something, this test method isn't testing anything related to value objects. I initially thought this might be an oversight in the declaration of the `SimpleValue` class and it probably was missing the `value` modifier. But this test method expects instances of `SimpleValue` to be serialized and deserialized without any exceptions, which is contrary to what is being proposed for value objects in context of JEP-401. test/jdk/java/io/Serializable/valueObjects/SimpleValueGraphs.java line 127: > 125: @MethodSource("migrationObjects") > 126: public void treeVTest(Object origObj, String origName, String > replName, Object expectedObject) throws Exception { > 127: byte[] bytes = serialize(origObj); This test method too I think will need some clean up. The `expectedObject` passed to this method is never an instance of `Exception` so the try/catch block in this test method shouldn't exist and the: > @param expectedObject the expected object (graph) or an exception if it > should fail should be updated to remove the mention of the exception. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3486004849 PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3486007267
