On Tue, 30 Jun 2026 15:53:32 GMT, Jaikiran Pai <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2859 commits: >> >> - Merge branch '8317277' into jep401_sub_review_8317279 >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - Merge >> >> Merge jdk-28+4 >> - 8386963: [lworld] Improve the exception message from Object >> synchronization methods on value objects >> >> Reviewed-by: dholmes, alanb >> - 8387300: [lworld] Minor review comments in javac >> >> Reviewed-by: vromero >> - 8387192: [lworld] Review comment drop for core libs >> >> Reviewed-by: jvernee, vromero >> - 8386999: [lworld] C2: assert(is_dead_loop_safe()) failed: shouldn't be >> cleared yet >> >> Reviewed-by: qamai, vlivanov >> - 8386787: [lworld] >> compiler/valhalla/inlinetypes/TestValueConstruction.java#StressIncrementalInliningDontInlineMyAbstractInit >> timed out >> >> Reviewed-by: phubner, chagedorn >> - 8386995: [lworld] Duplicate value classes are a preview feature warning >> >> Reviewed-by: alanb, vromero >> - 8383389: [lworld] Augment AOTMapLogger::print_oop_details to support flat >> arrays with oops >> >> Reviewed-by: iklam, fparain >> - ... and 2849 more: https://git.openjdk.org/jdk/compare/193de1b1...cdbe55a9 > > src/java.base/share/classes/jdk/internal/util/ReferencedKeyMap.java line 52: > >> 50: * accomplished by using a backing map where the keys are either a >> 51: * {@link WeakReference} or a {@link SoftReference}. >> 52: * Keys must be {@linkplain Class#isIdentity() identity objects.} > > There is a typo here. `Class` doesn't have an `isIdentity()` method in this > version of the JEP implementation. I'll file an issue to fix it and to link > it to `Class.isValue()`. Hmm. There are build warning for javadoc link issues like that. If those warnings were disabled, they should be re-enabled before integration. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3500162216
