On Fri, 17 Jul 2026 10:28:25 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Andrew Haley has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Merge branch 'JDK-8134940' of https://github.com/theRealAph/jdk into >> JDK-8134940 >> - x86 review fixes >> - Review comments > > src/hotspot/share/c1/c1_LIRGenerator.cpp line 967: > >> 965: data_offset_reg, as_BasicType(if_instr->x()->type())); >> 966: >> 967: LIR_Opr tmp = new_register(T_INT); > > Please cross-check if these temps really need to be `T_LONG` on `LP64`? There > are other `new_register(T_INT)`-s in this patch as well. It looks like the > BranchData cells are intptr_t, so this tmp may end up dealing with it? Our > automatic tools have discovered the `ldr x3` -> `ldr w3` change is tier3 > assembly, but I have not checked myself. Yes, I need to DTRT here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3692148160
