On Mon, 3 Aug 2026 13:55:48 GMT, Matthias Baesken <[email protected]> wrote:
> Currently we have a configure flag (--disable-cds-archive-nocoh) to disable > cds archive creation for NOCOH (no compact object headers). > Provide a similar configure flags to disable cds archive creation for NOCOOPS > (no compressed oops; --disable-cds-archive-nocoops) and the new _preview jsa > files (--disable-cds-archive-preview ) . > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Looks good overall, minor findings. make/autoconf/configure.ac line 265: > 263: JDKOPT_ENABLE_DISABLE_CDS_ARCHIVE_NOCOH > 264: JDKOPT_ENABLE_DISABLE_CDS_ARCHIVE_PREVIEW > 265: JDKOPT_ENABLE_DISABLE_CDS_ARCHIVE_NOCOOPS please exchange these parameters for better alphabetical sorting. make/autoconf/jdk-options.m4 line 800: > 798: UTIL_ARG_ENABLE(NAME: cds-archive-nocoh, DEFAULT: auto, RESULT: > BUILD_CDS_ARCHIVE_NOCOH, > 799: DESC: [enable generation of default CDS archives for no compact > object headers (requires --enable-cds-archive)], > 800: DEFAULT_DESC: [auto], If you want, you can remove DEFAULT_DESC here as well because it is redundant and would print "auto" anyway. make/autoconf/jdk-options.m4 line 827: > 825: UTIL_ARG_ENABLE(NAME: cds-archive-preview, DEFAULT: true, RESULT: > BUILD_CDS_ARCHIVE_PREVIEW, > 826: DESC: [enable generation of preview CDS archives (requires > --enable-cds-archive)], > 827: DEFAULT_DESC: [enable generation of preview CDS archives], remove the DEFAULT_DESC option, then the default description should be "enabled", which makes more sense than `enable generation of preview CDS archives` make/autoconf/jdk-options.m4 line 836: > 834: UTIL_ARG_ENABLE(NAME: cds-archive-nocoops, DEFAULT: true, RESULT: > BUILD_CDS_ARCHIVE_NOCOOPS, > 835: DESC: [enable generation of no compressed oops CDS archives > (requires --enable-cds-archive)], > 836: DEFAULT_DESC: [enable generation of no compressed oops CDS > archives], Same here, remove DEFAULT_DESC make/autoconf/jdk-options.m4 line 840: > 838: AC_SUBST(BUILD_CDS_ARCHIVE_NOCOOPS) > 839: ]) > 840: Please also switch these options for better alphabetical sorting. make/autoconf/spec.gmk.template line 376: > 374: BUILD_CDS_ARCHIVE_NOCOH := @BUILD_CDS_ARCHIVE_NOCOH@ > 375: BUILD_CDS_ARCHIVE_PREVIEW := @BUILD_CDS_ARCHIVE_PREVIEW@ > 376: BUILD_CDS_ARCHIVE_NOCOOPS := @BUILD_CDS_ARCHIVE_NOCOOPS@ Same here, switch for sorting. ------------- Changes requested by clanger (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/32174#pullrequestreview-4845060974 PR Review Comment: https://git.openjdk.org/jdk/pull/32174#discussion_r3704735824 PR Review Comment: https://git.openjdk.org/jdk/pull/32174#discussion_r3705122857 PR Review Comment: https://git.openjdk.org/jdk/pull/32174#discussion_r3705109114 PR Review Comment: https://git.openjdk.org/jdk/pull/32174#discussion_r3705110861 PR Review Comment: https://git.openjdk.org/jdk/pull/32174#discussion_r3705114421 PR Review Comment: https://git.openjdk.org/jdk/pull/32174#discussion_r3705116542
