On Tue, 28 Jul 2026 09:19:24 GMT, Manuel Hässig <[email protected]> wrote:
> This PR aims to compile the compiler testlibrary in > `tests/hotspot/jtreg/compiler/lib` into the `test-image`. However, this does > not change how compiler tests using these libraries are run; they are still > compiled by jtreg when running tests. This change is a convenience to be able > to mechanically reduce tests using the IR or template frameworks without > jtreg and thus needing those dependencies. > > Testing: > - [ ] Github Actions > - [x] tier1,tier2,tier3 > > Thanks, > Manuel > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). I think this looks good, but I'm hesitant on the top level make target. The word "compiler" in the context of Hotspot is obvious, but in the global context of the JDK build, "compiler" is ambiguous. There is also an existing target `build-test-lib` which we should probably match better style wise. Can we come up with something better? I would suggest `build-test-hotspot-compiler-lib` and `test-image-hotspot-compiler-lib` to match existing patterns. ------------- PR Review: https://git.openjdk.org/jdk/pull/32066#pullrequestreview-4886621299
