Hi,
I want to ask about your input on warnings about unused variables.
Currently we generally warn about this on UNIX , but switch it off for quite a
few (JDK) native libraries.
On Windows we could enable the warning (C4189) too.
See
https://bugs.openjdk.org/browse/JDK-8388932
8388932: Enable 'local variable is initialized but not referenced' warnings
with MSVC in JDK
Should we do so ?
I looked a bit into this, and already fixed a number of remaining unused
variable warnings.
For the JDK native libs it is mostly easy/straightforward.
Unfortunately for Hotspot it is different, because the codebase contains LOTS
of asserts , and those use variables that are flagged “unused” in the product
builds ; any opinions on this ?
Best regards, Matthias
