On Fri, 14 Aug 2026 17:08:52 GMT, Vladimir Ivanov <[email protected]> wrote:
> Tests results should not be deleted if current run do selection by status. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). make/RunTests.gmk line 1061: > 1059: $$(RM) -r $$($1_TEST_SUPPORT_DIR) > 1060: $$(RM) -r $$($1_TEST_RESULTS_DIR) > 1061: endif I think this is ok, but as I'm a very rare user of this myself, I would like more inputs on if this could backfire in any way. Stylewise when mixing make conditionals and recipes we align and indent them together, but with spaces for the make conditionals. So in this case, 8 spaces for the `ifeq` and `endif` and tab+2spaces for the recipe lines inside the block. Suggestion: ifeq ($(JTREG_STATUS),) $$(call LogWarn, Clean up dirs for $1) $$(RM) -r $$($1_TEST_SUPPORT_DIR) $$(RM) -r $$($1_TEST_RESULTS_DIR) endif ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32377#discussion_r3786568813
