On Thu, 6 Aug 2026 13:32:24 GMT, Kevin Walls <[email protected]> wrote:

>> This implements "jcmd on core files" for Linux, and for MiniDumps on Windows 
>> (MacOS is "future work").
>> jcmd "revives" the VM memory and .so/.dll from the core/minidump, and runs 
>> the existing native diagnostic command parser and command implementations.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Kevin Walls has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains 36 commits:
> 
>  - Merge branch 'master' into 8378084_jep_cores_impl
>  - Merge remote-tracking branch 'upstream/master' into 8378084_jep_cores_impl
>  - HotSpotAttachProvider back to only checking file exists
>  - tweak
>  - Attach API update on feedback
>  - Attach API implNote
>  - Move librevival_support to Linux specific directory
>  - include order
>  - Clear revived mutex to zeros, before re-init.
>  - Use accessor to access _mutex
>  - ... and 26 more: https://git.openjdk.org/jdk/compare/ab2dbf2a...9e9f7232

src/hotspot/share/classfile/dictionary.cpp line 2:

> 1: /*
> 2:  * Copyright (c) 2003, 2026, Oracle and/or its affiliates. All rights 
> reserved.

Unneeded copyright update.

src/hotspot/share/classfile/stringTable.cpp line 731:

> 729: 
> 730: TableStatistics StringTable::get_table_statistics() {
> 731:   TableStatistics ts;

We should fix these separately.  It shouldn't print the table if it can't get 
the lock to get statistics on the table.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3830308489
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3830311917

Reply via email to