On Mon, 24 Aug 2026 13:37:17 GMT, Erik Joelsson <[email protected]> wrote:
>> Alexandre Iline has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Pass JCOV_SCALES through TEST_OPTS > > make/RunTests.gmk line 125: > >> 123: JCOV_GRABBER_OPTIONS ?= >> 124: JCOV_REPGEN_OPTIONS ?= >> 125: JCOV_SCALES ?= false > > Variables expected to be set as arguments should use one of the keyword > variables, either TEST_OPTS, if this applies generally, or JTREG if this > applies only to jtreg tests, or both for convenience. > > These exist to provide some level of validation on arguments. If you run > "make ... JCOV_SCALES=true", you will get the following warning: > > > Note: Command line contains non-control variables: > * JCOV_SCALES=true > Make sure it is not mistyped, and that you intend to override this variable. > 'make help' will list known control variables. > > > If you make it a keyword variable argument, then the warning disappears, and > you get the added benefit a warning if you misspell it. > > If this is a Jtreg only option, then just add `JCOV_SCALES` to the > `SINGLE_KEYWORDS` argument of the ParseKeywordVariable call for `JTREG`. Then > you get the value in `JTREG_JCOV_SCALES`. If this applies to other test > frameworks it can get a bit more involved. Let me know. Fixed, please review. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32489#discussion_r3858396409
