On Tue, 25 Aug 2026 17:53:39 GMT, Boris Ulasevich <[email protected]> 
wrote:

>> It seems that compiler/valhalla/inlinetypes/TestLWorldProfiling.java is 
>> failing on all platforms, and I find no record in JBS that we have seen it 
>> fail like this else where. I can't see why it should fail with your changes 
>> though.
>
>> It seems that compiler/valhalla/inlinetypes/TestLWorldProfiling.java is 
>> failing on all platforms, and I find no record in JBS that we have seen it 
>> fail like this else where. I can't see why it should fail with your changes 
>> though.
> 
> It was about unusual VM options -XX:+UseArrayLoadStoreProfile 
> -XX:TypeProfileLevel=0 - I needed to check both of them in 
> profile_array_accesses:
> 
> bool MethodData::profile_array_accesses() {
>   return COMPILER2_PRESENT(UseArrayLoadStoreProfile ||) TypeProfileLevel > 0;
> }
> 
> With the latest commit the test passes.

@bulasevich  please pay attention to the messages and stop force-pushing! You 
have broken the PR history and continuity. People can no longer look at the 
incremental changes you have made. Just merge with master and push that Merge 
commit to update your branch. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32402#issuecomment-5435479910

Reply via email to