On Mon, 21 Sep 2026 12:19:32 GMT, Manuel Hässig <[email protected]> wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address Ashutosh's comments
>
> src/hotspot/share/opto/doCall.cpp line 621:
>
>> 619: clinit_barrier(holder_klass, method());
>> 620: if (stopped()) {
>> 621: return; // MUST uncommon-trap?
>
> Could you explain this comment?
Stopped means that class initialization state check is constant fold and we
have only uncommon trap on the path. But it contradicts assumption that
`holder_klass` should be initialized in AOT "preload" code. See
`CompileTask::Reason_AOTCompileForPreload` case in
`ciEnv::compute_init_state_for_aot_compile()`.
But I put this check here anyway to be safe if in a future we made changes. I
will update the comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30778#discussion_r4064375195
