On Tue, 20 Oct 2026 16:48:50 GMT, Ioi Lam <[email protected]> wrote:

> The C++ class `SystemDictionaryShared` should be renamed to 
> `AOTSystemDictionary`, to be consistent with the rest of the AOT code.
> 
> This RFE changes only class names. Further changes are needed to rename the 
> various `xxx_shared_xxx` symbols in the C++ code.
> 
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Renaming/relocation looks fine.

A couple of minor queries.

make/hotspot/lib/JvmFeatures.gmk line 124:

> 122:   JVM_EXCLUDE_FILES += \
> 123:       aotCodeCache.cpp \
> 124:       aotCompileBroker.cpp \

So are there not AOT specific files that should be excluded in place of these?

We have "cds" as a JVM-feature - is "aot" also a JVM-feature?

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/33475#pullrequestreview-5623732264
PR Review Comment: https://git.openjdk.org/jdk/pull/33475#discussion_r4355954494

Reply via email to