On Thu, Oct 16, 2008 at 10:09 AM, Victor Hugo Borja <[EMAIL PROTECTED]> wrote: > On Thu, Oct 16, 2008 at 10:54 AM, Assaf Arkin <[EMAIL PROTECTED]> wrote: > >> On Thu, Oct 16, 2008 at 6:38 AM, Victor Hugo Borja <[EMAIL PROTECTED]> >> wrote: >> > Are you testing the master branch ?, IIRC the rake 0.8.3 branch has not >> been >> > merged on master. >> >> I updated head/trunk to more recent versions of RSpec, and in separate >> update Rake 0.8.3, to find out what the changes are. I'm curious if >> anything will break besides application.rb. >> > > Some changes to application_cli.rb are needed, the one in rake-0.8.3 branch > uses OptionParser instead of getopt as rakes does. > application_cli.rb[1] doesn't depends on rake options or how rake parses > them, so further changes from rake wont affect us.
Why not use the same code as Rake? It's simpler and we already build on Rake. Speaking of, this would be a good time to remove application_cli. I have a hard enough time with Application split between Buildr and Rake code base, breaking the class further just makes it harder to maintain. The only reason I found for application_cli to exist is Nailgun, and if Nailgun is not building a new application and only accessing the options list, can't it just call Application.new.standard_rake_options? Assaf > > I'll possibly merge the rake-0.8.3 branch into master in a couple of hours. > > [1] > http://github.com/vic/buildr/tree/rake-0.8.3/lib/buildr/core/application_cli.rb > -- > vic > > Quaerendo invenietis. >
