|
apache
/
flink
|
|
master
|
31 hrs, 30 mins, 9 secs
|
Zhijiang
|
|
[FLINK-13442][network] Remove unnecessary notifySubpartitionConsumed method from view reader
Currently the methods of NetworkSequenceViewReader#notifySubpartitionConsumed and NetworkSequenceViewReader#releaseAllResources would be called meanwhile in netty stack during releasing resources.
As confirmed in FLINK-13245, in order to make this release logic simple and clean, we could remove the redundant notifySubpartitionConsumed from NetworkSequenceViewReader side, and also remove it from ResultSubpartitionView side. In the implementation of ResultSubpartitionView#releaseAllResources it would further notify the parent subpartition of consumed state via ResultSubpartition#notifySubpartitionConsumed which further feedback to parent ResultPartition layer via onConsumedSubpartition. Finally ResultPartition could decide whether to release itself or not.
E.g. for the case of ReleaseOnConsumptionResultPartition which is mainly used for pipelined partition, it would release partition after reference counter decreased to 0. For the case of ResultPartition which would be generated for blocking partition by default, it would never be released after notifying consumed. And the JM/scheduler would decide when to release partition properly.In addition, InputChannel#notifySubpartitionConsumed could also be removed as a result of above.
|
|