See 
<https://ci-builds.apache.org/job/Guacamole/job/guacamole-server-main-coverity/221/display/redirect?page=changes>

Changes:

[pgrabczak] GUACAMOLE-2221: fix RDP busy-loop on transport failure


------------------------------------------
[...truncated 241.07 KiB...]
#8 118.6   CC       libguac_la-socket-nest.lo
#8 120.3   CC       libguac_la-socket-tee.lo
#8 121.8   CC       libguac_la-string.lo
#8 123.2   CC       libguac_la-tcp.lo
#8 124.9   CC       libguac_la-timestamp.lo
#8 126.0   CC       libguac_la-unicode.lo
#8 127.1   CC       libguac_la-user.lo
#8 129.1   CC       libguac_la-user-handlers.lo
#8 131.5   CC       libguac_la-user-handshake.lo
#8 133.4   CC       libguac_la-wait-fd.lo
#8 134.5   CC       libguac_la-wol.lo
#8 136.2   CC       libguac_la-encode-webp.lo
#8 138.2   CC       libguac_la-socket-ssl.lo
#8 141.4   CCLD     libguac.la
#8 143.6 make[3]: Leaving directory '/build/guacamole-server/src/libguac'
#8 143.6 Making all in tests
#8 143.6 make[3]: Entering directory '/build/guacamole-server/src/libguac/tests'
#8 143.6 make[3]: Nothing to be done for 'all'.
#8 143.6 make[3]: Leaving directory '/build/guacamole-server/src/libguac/tests'
#8 143.6 make[2]: Leaving directory '/build/guacamole-server/src/libguac'
#8 143.6 Making all in src/common
#8 143.6 make[2]: Entering directory '/build/guacamole-server/src/common'
#8 143.6 Making all in .
#8 143.6 make[3]: Entering directory '/build/guacamole-server/src/common'
#8 143.6   CC       libguac_common_la-io.lo
#8 144.8   CC       libguac_common_la-blank_cursor.lo
#8 146.3   CC       libguac_common_la-clipboard.lo
#8 148.1   CC       libguac_common_la-cursor.lo
#8 150.1   CC       libguac_common_la-dot_cursor.lo
#8 151.5   CC       libguac_common_la-ibar_cursor.lo
#8 152.9   CC       libguac_common_la-iconv.lo
#8 154.2   CC       libguac_common_la-json.lo
#8 155.9   CC       libguac_common_la-list.lo
#8 157.4   CC       libguac_common_la-pointer_cursor.lo
#8 159.0   CC       libguac_common_la-rect.lo
#8 160.2   CC       libguac_common_la-string.lo
#8 161.6   CC       libguac_common_la-surface.lo
#8 164.7   CCLD     libguac_common.la
#8 165.2 make[3]: Leaving directory '/build/guacamole-server/src/common'
#8 165.2 Making all in tests
#8 165.3 make[3]: Entering directory '/build/guacamole-server/src/common/tests'
#8 165.3 make[3]: Nothing to be done for 'all'.
#8 165.3 make[3]: Leaving directory '/build/guacamole-server/src/common/tests'
#8 165.3 make[2]: Leaving directory '/build/guacamole-server/src/common'
#8 165.3 Making all in src/common-ssh
#8 165.3 make[2]: Entering directory '/build/guacamole-server/src/common-ssh'
#8 165.3 Making all in .
#8 165.3 make[3]: Entering directory '/build/guacamole-server/src/common-ssh'
#8 165.3   CC       libguac_common_ssh_la-buffer.lo
#8 166.9   CC       libguac_common_ssh_la-sftp.lo
#8 169.2   CC       libguac_common_ssh_la-ssh.lo
#8 172.9   CC       libguac_common_ssh_la-key.lo
#8 176.2   CC       libguac_common_ssh_la-user.lo
#8 178.0   CCLD     libguac_common_ssh.la
#8 178.6 make[3]: Leaving directory '/build/guacamole-server/src/common-ssh'
#8 178.6 Making all in tests
#8 178.6 make[3]: Entering directory 
'/build/guacamole-server/src/common-ssh/tests'
#8 178.6 make[3]: Nothing to be done for 'all'.
#8 178.6 make[3]: Leaving directory 
'/build/guacamole-server/src/common-ssh/tests'
#8 178.6 make[2]: Leaving directory '/build/guacamole-server/src/common-ssh'
#8 178.6 Making all in src/terminal
#8 178.6 make[2]: Entering directory '/build/guacamole-server/src/terminal'
#8 178.6 Making all in .
#8 178.6 make[3]: Entering directory '/build/guacamole-server/src/terminal'
#8 178.6   CC       libguac_terminal_la-buffer.lo
#8 181.0   CC       libguac_terminal_la-char-mappings.lo
#8 182.1   CC       libguac_terminal_la-color-scheme.lo
#8 184.1   CC       libguac_terminal_la-common.lo
#8 185.5   CC       libguac_terminal_la-display.lo
#8 190.5   CC       libguac_terminal_la-named-colors.lo
#8 191.9   CC       libguac_terminal_la-palette.lo
#8 193.1   CC       libguac_terminal_la-scrollbar.lo
#8 195.1   CC       libguac_terminal_la-select.lo
#8 198.5   CC       libguac_terminal_la-selection-point.lo
#8 199.6   CC       libguac_terminal_la-terminal.lo
#8 205.3   CC       libguac_terminal_la-terminal-handlers.lo
#8 209.9   CC       libguac_terminal_la-terminal-stdin-stream.lo
#8 213.4   CC       libguac_terminal_la-typescript.lo
#8 215.1   CC       libguac_terminal_la-xparsecolor.lo
#8 216.3   CCLD     libguac-terminal.la
#8 218.3 make[3]: Leaving directory '/build/guacamole-server/src/terminal'
#8 218.3 Making all in tests
#8 218.3 make[3]: Entering directory 
'/build/guacamole-server/src/terminal/tests'
#8 218.3 make[3]: Nothing to be done for 'all'.
#8 218.3 make[3]: Leaving directory '/build/guacamole-server/src/terminal/tests'
#8 218.3 make[2]: Leaving directory '/build/guacamole-server/src/terminal'
#8 218.3 Making all in src/pulse
#8 218.3 make[2]: Entering directory '/build/guacamole-server/src/pulse'
#8 218.3   CC       libguac_pulse_la-pulse.lo
#8 220.3   CCLD     libguac_pulse.la
#8 220.9 make[2]: Leaving directory '/build/guacamole-server/src/pulse'
#8 220.9 Making all in src/protocols/kubernetes
#8 220.9 make[2]: Entering directory 
'/build/guacamole-server/src/protocols/kubernetes'
#8 220.9 Making all in .
#8 220.9 make[3]: Entering directory 
'/build/guacamole-server/src/protocols/kubernetes'
#8 220.9   CC       libguac_client_kubernetes_la-argv.lo
#8 225.9   CC       libguac_client_kubernetes_la-client.lo
#8 231.0   CC       libguac_client_kubernetes_la-clipboard.lo
#8 235.9   CC       libguac_client_kubernetes_la-input.lo
#8 240.4   CC       libguac_client_kubernetes_la-io.lo
#8 245.2   CC       libguac_client_kubernetes_la-pipe.lo
#8 250.0   CC       libguac_client_kubernetes_la-settings.lo
#8 254.7   CC       libguac_client_kubernetes_la-ssl.lo
#8 260.1   CC       libguac_client_kubernetes_la-kubernetes.lo
#8 265.6   CC       libguac_client_kubernetes_la-url.lo
#8 267.2   CC       libguac_client_kubernetes_la-user.lo
#8 272.1   CCLD     libguac-client-kubernetes.la
#8 274.0 make[3]: Leaving directory 
'/build/guacamole-server/src/protocols/kubernetes'
#8 274.0 Making all in tests
#8 274.0 make[3]: Entering directory 
'/build/guacamole-server/src/protocols/kubernetes/tests'
#8 274.0 make[3]: Nothing to be done for 'all'.
#8 274.0 make[3]: Leaving directory 
'/build/guacamole-server/src/protocols/kubernetes/tests'
#8 274.0 make[2]: Leaving directory 
'/build/guacamole-server/src/protocols/kubernetes'
#8 274.0 Making all in src/protocols/rdp
#8 274.1 make[2]: Entering directory '/build/guacamole-server/src/protocols/rdp'
#8 274.1   GEN      _generated_channel_entry_wrappers.c
#8 274.1   GEN      _generated_keymaps.c
#8 274.1 Added: base
#8 274.1 Added: base_altgr
#8 274.1 Added: failsafe
#8 274.1 Added: cs-cz-qwertz
#8 274.1 Added: de-de-qwertz
#8 274.1 Added: de-ch-qwertz
#8 274.1 Added: en-gb-qwerty
#8 274.1 Added: en-us-qwerty
#8 274.1 Added: es-es-qwerty
#8 274.1 Added: es-latam-qwerty
#8 274.1 Added: fr-be-azerty
#8 274.1 Added: fr-ca-qwerty
#8 274.1 Added: fr-ch-qwertz
#8 274.1 Added: fr-fr-azerty
#8 274.1 Added: hu-hu-qwertz
#8 274.1 Added: it-it-qwerty
#8 274.1 Added: ja-jp-qwerty
#8 274.2 Added: no-no-qwerty
#8 274.2 Added: pl-pl-qwerty
#8 274.2 Added: pt-br-qwerty
#8 274.2 Added: pt-pt-qwerty
#8 274.2 Added: ro-ro-qwerty
#8 274.2 Added: sv-se-qwerty
#8 274.2 Added: da-dk-qwerty
#8 274.2 Added: tr-tr-qwerty
#8 274.2 make  all-recursive
#8 274.2 make[3]: Entering directory '/build/guacamole-server/src/protocols/rdp'
#8 274.2 Making all in .
#8 274.2 make[4]: Entering directory '/build/guacamole-server/src/protocols/rdp'
#8 274.2   CC       
plugins/guac-common-svc/libguac_common_svc_client_la-guac-common-svc.lo
#8 277.6   CCLD     libguac-common-svc-client.la
#8 278.4   CC       channels/audio-input/libguacai_client_la-audio-buffer.lo
#8 281.7   CC       plugins/guacai/libguacai_client_la-guacai-messages.lo
#8 285.3   CC       plugins/guacai/libguacai_client_la-guacai.lo
#8 289.0   CC       plugins/libguacai_client_la-ptr-string.lo
#8 290.6   CCLD     libguacai-client.la
#8 291.4   CC       libguac_client_rdp_la-argv.lo
#8 295.0   CC       libguac_client_rdp_la-beep.lo
#8 298.1   CC       channels/audio-input/libguac_client_rdp_la-audio-buffer.lo
#8 299.7   CC       channels/audio-input/libguac_client_rdp_la-audio-input.lo
#8 303.2   CC       channels/libguac_client_rdp_la-cliprdr.lo
#8 306.6   CC       channels/libguac_client_rdp_la-common-svc.lo
#8 309.6   CC       channels/libguac_client_rdp_la-disp.lo
#8 313.2   CC       channels/libguac_client_rdp_la-pipe-svc.lo
#8 316.7   CC       channels/libguac_client_rdp_la-rail.lo
#8 320.3   CC       
channels/rdpdr/libguac_client_rdp_la-rdpdr-fs-messages-dir-info.lo
#8 323.8   CC       
channels/rdpdr/libguac_client_rdp_la-rdpdr-fs-messages-file-info.lo
#8 327.4   CC       
channels/rdpdr/libguac_client_rdp_la-rdpdr-fs-messages-vol-info.lo
#8 330.8   CC       channels/rdpdr/libguac_client_rdp_la-rdpdr-fs-messages.lo
#8 334.4   CC       channels/rdpdr/libguac_client_rdp_la-rdpdr-fs.lo
#8 337.8   CC       channels/rdpdr/libguac_client_rdp_la-rdpdr-messages.lo
#8 341.4   CC       channels/rdpdr/libguac_client_rdp_la-rdpdr-printer.lo
#8 344.7   CC       channels/rdpdr/libguac_client_rdp_la-rdpdr.lo
#8 347.9   CC       channels/libguac_client_rdp_la-rdpei.lo
#8 351.2   CC       channels/libguac_client_rdp_la-rdpgfx.lo
#8 354.5   CC       channels/rdpsnd/libguac_client_rdp_la-rdpsnd-messages.lo
#8 358.0   CC       channels/rdpsnd/libguac_client_rdp_la-rdpsnd.lo
#8 361.3   CC       libguac_client_rdp_la-client.lo
#8 364.7   CC       libguac_client_rdp_la-color.lo
#8 368.2   CC       libguac_client_rdp_la-decompose.lo
#8 371.1   CC       libguac_client_rdp_la-download.lo
#8 374.5   CC       libguac_client_rdp_la-error.lo
#8 377.7   CC       libguac_client_rdp_la-fs.lo
#8 380.5   CC       libguac_client_rdp_la-gdi.lo
#8 384.1   CC       libguac_client_rdp_la-input.lo
#8 387.6   CC       libguac_client_rdp_la-input-queue.lo
#8 391.1   CC       libguac_client_rdp_la-keyboard.lo
#8 395.2   CC       libguac_client_rdp_la-keymap.lo
#8 396.6   CC       libguac_client_rdp_la-log.lo
#8 398.5   CC       libguac_client_rdp_la-ls.lo
#8 400.8   CC       plugins/libguac_client_rdp_la-channels.lo
#8 404.3   CC       plugins/libguac_client_rdp_la-ptr-string.lo
#8 405.3   CC       libguac_client_rdp_la-pointer.lo
#8 408.8   CC       libguac_client_rdp_la-print-job.lo
#8 412.7   CC       libguac_client_rdp_la-rdp.lo
#8 414.4 rdp.c: In function 'guac_rdp_client_thread':
#8 414.4 rdp.c:658:12: error: 'connection_closing' may be used uninitialized in 
this function [-Werror=maybe-uninitialized]
#8 414.4          if (connection_closing)
#8 414.4             ^
#8 414.4 rdp.c:627:13: note: 'connection_closing' was declared here
#8 414.4          int connection_closing;
#8 414.4              ^~~~~~~~~~~~~~~~~~
#8 414.5 cc1: all warnings being treated as errors
#8 414.5 make[4]: *** [Makefile:1355: libguac_client_rdp_la-rdp.lo] Error 1
#8 414.5 make[4]: Leaving directory '/build/guacamole-server/src/protocols/rdp'
#8 414.5 make[3]: *** [Makefile:1472: all-recursive] Error 1
#8 414.5 make[3]: Leaving directory '/build/guacamole-server/src/protocols/rdp'
#8 414.5 make[2]: *** [Makefile:762: all] Error 2
#8 414.5 make[2]: Leaving directory '/build/guacamole-server/src/protocols/rdp'
#8 414.5 make[1]: *** [Makefile:542: all-recursive] Error 1
#8 414.5 make[1]: Leaving directory '/build/guacamole-server'
#8 414.5 make: *** [Makefile:462: all] Error 2
#8 415.7 Attempting to detect unconfigured compilers in build
#8 415.7 |0----------25-----------50----------75---------100|
#8 415.8 ****************************************************
#8 417.0 [WARNING] Build command make exited with code 2. Please verify that 
the build completed successfully.
#8 417.0 Emitted 271 C/C++ compilation units (100%) successfully
#8 417.0 
#8 417.0 271 C/C++ compilation units (100%) are ready for analysis
#8 417.0  For more details, please look at: 
#8 417.0     /build/guacamole-server/cov-int/build-log.txt
#8 ERROR: process "/bin/sh -c /bin/bash -e -x /build/build.sh" did not complete 
successfully: exit code: 2
------
 > [4/4] RUN /bin/bash -e -x /build/build.sh:
414.5 make[1]: Leaving directory '/build/guacamole-server'
414.5 make: *** [Makefile:462: all] Error 2
415.7 Attempting to detect unconfigured compilers in build
*****
417.0 [WARNING] Build command make exited with code 2. Please verify that the 
build completed successfully.
417.0 Emitted 271 C/C++ compilation units (100%) successfully
417.0 
417.0 271 C/C++ compilation units (100%) are ready for analysis
417.0  For more details, please look at: 
417.0     /build/guacamole-server/cov-int/build-log.txt
------

 4 warnings found (use docker --debug to expand):
 - SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive 
data (ARG "COVERITY_TOKEN") (line 3)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV 
key value" format (line 4)
 - SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data 
(ENV "COVERITY_TOKEN") (line 4)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV 
key value" format (line 7)
Dockerfile:11
--------------------
   9 |       COPY . /build/
  10 |       RUN /bin/bash -e -x /build/install-deps.sh
  11 | >>>   RUN /bin/bash -e -x /build/build.sh
  12 |     
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c /bin/bash -e -x 
/build/build.sh" did not complete successfully: exit code: 2
+ docker rmi --force guac-jenkins-guacamole-guacamole-server-main-coverity-221
Error response from daemon: No such image: 
guac-jenkins-guacamole-guacamole-server-main-coverity-221:latest
Build step 'Execute shell' marked build as failure

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to