The GitHub Actions job "CI" on kvrocks.git/unstable has succeeded.
Run started by GitHub user jihuayu (triggered by jihuayu).

Head commit for run:
4aede367b72416a591623c2f04f176ab3e74c40a / Songqing Zhang 
<[email protected]>
fix(string,hash): use compact float format in IncrByFloat to match Redis (#3427)

Previously, String::IncrByFloat and Hash::IncrByFloat used
std::to_string(double) to persist float values, which produces C-style
%f format with 6 fixed decimal places (e.g., "10.500000"). Redis uses a
    compact %g-like format that strips trailing zeros (e.g., "10.5").

    This caused GET/HGET after INCRBYFLOAT/HINCRBYFLOAT to return values
like "10.500000" instead of "10.5", breaking Redis protocol
compatibility.

Replace std::to_string with util::Float2String (which uses fmt {:.17g})
    in both String::IncrByFloat and Hash::IncrByFloat. The INCRBYFLOAT
command reply already used Float2String correctly; this fix aligns the
    stored representation with both the reply format and Redis behavior.

Co-authored-by: 纪华裕 <[email protected]>

Report URL: https://github.com/apache/kvrocks/actions/runs/24135790855

With regards,
GitHub Actions via GitBox

Reply via email to