Hello,
Any objections to the attached patch? It's annoying that non-mock-group/non-
root users can't do even mock --help or --version.
From f6119edec00442368f2686e5f450bb53e0925fd6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ville=20Skytt=C3=A4?= <[email protected]>
Date: Mon, 22 Mar 2010 22:48:37 +0200
Subject: [PATCH] Make --help etc work for non-mock users.
---
py/mock.py | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/py/mock.py b/py/mock.py
index 5697ed2..1e9701a 100755
--- a/py/mock.py
+++ b/py/mock.py
@@ -462,7 +462,9 @@ def main(ret):
unprivGid = pwd.getpwuid(unprivUid)[3]
uidManager = mock.uid.uidManager(unprivUid, unprivGid)
- uidManager._becomeUser(unprivUid, unprivGid)
+ # go unpriv only when root to make --help etc work for non-mock users
+ if os.geteuid() == 0:
+ uidManager._becomeUser(unprivUid, unprivGid)
# defaults
config_opts = {}
--
1.7.0.1
--
buildsys mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/buildsys
