On Mon, 2011-03-07 at 22:33 +0200, Ville Skyttä wrote: > On 03/07/2011 10:19 PM, seth vidal wrote: > > On Mon, 2011-03-07 at 22:17 +0200, Ville Skyttä wrote: > >> Fixes shell escaping issues like in '--install "perl(Foo::Bar)"'. The > >> "canonical" syntax for chroot_setup_cmd in configs is now a tuple or a > >> list, but a string is still accepted for backwards compatibility (it > >> gets split to list internally). > > > > I think I'd be more inclined to make it possible to accept the > > list/tuple but default to the string in the configs. > > > > it makes it easier to understand/read for people not familiar with > > python. > > Wow, that was quick, you beat me to writing the explanatory mail that > should have arrived by now :) > > Anyway, I don't have strong opinions either way, changing it to be the > way you suggested (and I discussed in the other mentioned mail) would be > a matter of not touching the config files and rewording the related > "deprecated" comment in code.
I see - sorry. I'd say drop the config file changes and leave the rest and maybe not call it deprecated but a supported mode that occasionally creates problems -sv -- buildsys mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/buildsys
